Review main Merged

71558[BUGFIX] PHP 8.0 warnings from ContentObjectRenderer

Christian Kuhn CR +2 V +2 Easy +14 −2 updated 10/12/21, 15:13

Commit message

The Format/HtmlViewHelper is designed to run in backend
without TSFE. The HtmlViewHelperTest with disabled error
suppression reveals ContentObjectRenderer does not always
properly check for instances of TypoScriptFrontentController.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Christian Kuhn uploaded patch set 1 10/12/21, 10:44

  2. core-ci voted on patch set 1 V -1 10/12/21, 11:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17961

  3. Christian Kuhn uploaded patch set 2 10/12/21, 11:29

  4. core-ci voted on patch set 2 V +1 10/12/21, 11:46 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17964

  5. Oliver Klee voted on patch set 2 CR +1 10/12/21, 12:30

  6. Jochen Roth voted on patch set 2 V +1 CR +1 10/12/21, 15:12

  7. Benni Mack voted on patch set 2 V +2 CR +2 10/12/21, 15:13

  8. Benni Mack merged patch set 3 10/12/21, 15:13