Review main Merged

71559[BUGFIX] Return ResponseInterface in test controllers

Christian Kuhn CR +2 V +2 Normal +29 −31 updated 10/12/21, 14:53

Commit message

Extbase functional tests with disabled error suppression
reveal there are still some tests with fixture classes
that don't return ResponseInterface in extbase action
controllers.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 79

  1. Christian Kuhn uploaded patch set 1 10/12/21, 11:01

  2. core-ci voted on patch set 1 V -1 10/12/21, 11:18 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17963

  3. Benni Mack commented on patch set 1 10/12/21, 11:23

    TestController.php:72

    wrong type hint
  4. Christian Kuhn uploaded patch set 2 10/12/21, 12:48

  5. Christian Kuhn commented on patch set 2 10/12/21, 13:00

    TestController.php:72 Reply

    Done
  6. core-ci voted on patch set 2 V +1 10/12/21, 13:12 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17970

  7. Wouter Wolters voted on patch set 2 V +1 CR +1 10/12/21, 14:47

  8. Benjamin Franzke voted on patch set 2 V +2 CR +2 10/12/21, 14:52

  9. Benjamin Franzke merged patch set 3 10/12/21, 14:53