Review main Merged

71564[BUGFIX] Use correct selector for caret animation in EXT:form

Jochen Roth CR +2 V +2 Easy +16 −29 updated 10/19/21, 13:14

Commit message

Currently the expanded tree does not reflect the state
(collapsed/expanded).

This has been fixed by using the correct css selector.
Also removed some obsolete styles.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • André Buchmann +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • André Buchmann +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1419

  1. Jochen Roth uploaded patch set 1 10/12/21, 13:09

  2. Jochen Roth marked it work in progress 10/12/21, 13:12

  3. Jochen Roth uploaded patch set 2 10/12/21, 13:19

  4. Jochen Roth marked it ready for review 10/12/21, 13:21

  5. core-ci voted on patch set 1 V +1 10/12/21, 13:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17973

  6. André Buchmann commented on patch set 2 V -1 10/12/21, 13:28

    Works only for the steps level. Element level still same issue.
  7. core-ci voted on patch set 2 V +1 10/12/21, 13:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17974

  8. Jochen Roth uploaded patch set 3 10/14/21, 14:34

  9. Jochen Roth uploaded patch set 4 10/14/21, 14:39

  10. core-ci voted on patch set 3 V -1 10/14/21, 14:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18105

  11. core-ci voted on patch set 4 V -1 10/14/21, 14:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18106

  12. Jochen Roth uploaded patch set 5 10/14/21, 15:10

  13. core-ci voted on patch set 5 V +1 10/14/21, 15:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18109

  14. André Buchmann commented on patch set 5 V +1 CR +1 10/18/21, 08:16

    Caret is no in correct position
  15. André Buchmann commented on patch set 5 10/18/21, 08:17

    Reply

    > Caret is no in correct position *now
  16. Nikita Hovratov commented on patch set 5 10/18/21, 08:29

    Reply

    Yes, can me make it like in the Pagetree? Something like that: #t3-form-structure-panel .mjs-nestedSortable-branch span[data-identifier="treeExpander"] { margin-left: -1.7em; margin-top: 2px; position: relative; z-index: 1; }
  17. Nikita Hovratov voted on patch set 5 V +1 10/18/21, 09:58

  18. Christian Kuhn voted on patch set 5 V +2 CR +2 10/19/21, 13:14

  19. Christian Kuhn merged patch set 6 10/19/21, 13:14