Review main Abandoned

71565[TASK] RootPaths are not ordered/sorted!

TYPO3com CR 0 V 0 Easy +6 −0 updated 11/09/21, 20:16

Commit message

Maybe somewhere else would be a better place to sort, after i added kSort
for all Paths i could finally override all Form Templates

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 24

  1. TYPO3com uploaded patch set 1 10/12/21, 13:49

  2. core-ci voted on patch set 1 V -1 10/12/21, 13:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17975

  3. Christian Kuhn commented on patch set 1 11/09/21, 20:16

    This reads pretty fishy as is currently: The statement "adding ksort so i could finally override all templates" is simply not enough. This misses a specification of the problem and a way on how to reproduce. I've set the category in forge of this issue to "Form Framework". More information can be added in the issue, hoping the ext:form maintainers will pick it up. For now, I'll abandon this patch, a solution may arise from more forge.typo3.org information. The patch can be resurrected if needed.
  4. Christian Kuhn abandoned the change 11/09/21, 20:16