Review main Abandoned

71566[TASK] Fixes FormContent-FinisherOverriding master

TYPO3com CR 0 V 0 Easy +25 −1 updated 11/09/21, 20:03

Commit message

My proposal to fix issue

https://forge.typo3.org/issues/95290

for TYPO3 v11 (master) - v11.4.0

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 4

Review log 24

  1. TYPO3com uploaded patch set 1 10/12/21, 13:49

  2. core-ci voted on patch set 1 V -1 10/12/21, 14:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17976

  3. Christian Kuhn commented on patch set 1 CR -2 11/09/21, 20:03

    Hey. This really looks

    FormResultCompiler.php:73 Unresolved

    This looks fishy: Adding a general label to this ext:backend class for ext:form is not the way to go. This patch won't make it in current state. I'll abandon the change. The issue will remain 'new', patches should be pushed fixing Issue https://forge.typo3.org/issues/95290
  4. Christian Kuhn abandoned the change 11/09/21, 20:03