Review main Merged

71567[BUGFIX] Incomplete setup in extbase PersistenceManager tests

Christian Kuhn CR +2 V +2 Easy +28 −0 updated 10/12/21, 14:53

Commit message

The persistence tests use ext:blog_example repositories
and miss to properly setup ConfigurationManager for this
extension, which is usually done by extbase bootstrap.

Running the functional tests without error
suppression reveal this incomplete setup.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Christian Kuhn uploaded patch set 1 10/12/21, 13:50

  2. core-ci voted on patch set 1 V +1 10/12/21, 14:13 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17977

  3. Wouter Wolters voted on patch set 1 V +1 CR +1 10/12/21, 14:46

  4. Benni Mack voted on patch set 1 V +2 CR +2 10/12/21, 14:53

  5. Benni Mack merged patch set 2 10/12/21, 14:53