Review main Merged

71596[BUGFIX] Add missing borders below tablesort th elements

Nikita Hovratov CR +2 V +2 Easy +2 −1 updated 10/13/21, 07:37

Commit message

While fixing an issue with sticky icons, the borders
below th elements with "position: relative" got
removed. This is fixed by adding the css property
"background-clip: padding-box" to them, as this
prevents the drawing of background beneath
borders.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Nikita Hovratov uploaded patch set 1 10/12/21, 16:28

  2. core-ci voted on patch set 1 V +1 10/12/21, 16:45 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17986

  3. Georg Ringer voted on patch set 1 V +1 CR +1 10/13/21, 04:21

  4. Benni Mack voted on patch set 1 V +2 CR +2 10/13/21, 07:37

  5. Benni Mack merged patch set 2 10/13/21, 07:37