Review main Merged

71597[TASK] Upgrade PHPStan to latest version 0.12.99

Wouter Wolters CR +2 V +2 Normal +44 −20 updated 11/03/21, 11:15

Commit message

This is the latest version before 1.0.0 release.
PHPStan 1.0 is going to be PHPStan 0.12.99 + bleeding edge + BC breaks.

composer req --dev phpstan/phpstan:^0.12.99

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
    • Simon Schaufelberger +1
    • Rudy Gnodde +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Jochen Roth +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 79

  1. Wouter Wolters uploaded patch set 1 10/12/21, 16:40

  2. core-ci voted on patch set 1 V +1 10/12/21, 16:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17987

  3. Anja Leichsenring uploaded patch set 2 11/03/21, 10:52

  4. Rudy Gnodde voted on patch set 2 CR +1 11/03/21, 10:56

  5. Simon Schaufelberger voted on patch set 2 V +1 CR +1 11/03/21, 10:59

  6. core-ci voted on patch set 2 V +1 11/03/21, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18778

  7. Jochen Roth voted on patch set 2 V +1 CR +1 11/03/21, 11:13

  8. Anja Leichsenring voted on patch set 2 V +2 CR +2 11/03/21, 11:15

  9. Anja Leichsenring merged patch set 3 11/03/21, 11:15