Review main Merged

71598[BUGFIX] Add EXTENSIONS array to DefaultConfiguration

Christian Kuhn CR +2 V +2 Easy +1 −0 updated 10/13/21, 02:57

Commit message

$GLOBALS['TYPO3_CONF_VARS']['EXTENSIONS'] stores extensions
specific settings - settings created from definitions in
ext_conf_template.typoscript files.

This array is not defined in DefaultConfiguration.php, it
was probably used to test for when the transition from
the serialized string to the flat array was done around
core v8 or so.

We can now safely add it as default-empty array to
DefaultConfiguration.php, so core can rely on existance
of this array key.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Josef Glatz +1
    • Wouter Wolters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 10/12/21, 18:29

  2. core-ci voted on patch set 1 V +1 10/12/21, 18:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17988

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 10/12/21, 20:19

  4. Wouter Wolters voted on patch set 1 V +1 CR +1 10/12/21, 21:39

  5. Josef Glatz voted on patch set 1 V +1 CR +1 10/13/21, 02:24

  6. Georg Ringer voted on patch set 1 V +2 CR +2 10/13/21, 02:57

  7. Georg Ringer merged patch set 2 10/13/21, 02:57