Review main Merged

71599[BUGFIX] Avoid undefined key access in extbase tests

Christian Kuhn CR +2 V +2 Easy +4 −4 updated 10/12/21, 19:36

Commit message

Some assertions in extbase functional tests access
not existing array keys, which raises PHP 8.0 warnings.
Sanitize these.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Christian Kuhn uploaded patch set 1 10/12/21, 18:44

  2. core-ci voted on patch set 1 V +1 10/12/21, 19:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17989

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 10/12/21, 19:21

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 10/12/21, 19:36

  5. Oli Bartsch merged patch set 2 10/12/21, 19:36