Review main Merged

71601[BUGFIX] Fix undefined array key access in ModuleLoader

Oli Bartsch CR +2 V +2 Easy +4 −4 updated 10/13/21, 09:09

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 10/12/21, 19:51

  2. core-ci voted on patch set 1 V +1 10/12/21, 20:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17992

  3. Wouter Wolters commented on patch set 1 10/12/21, 21:41

    ModuleLoader.php:194

    null is also not false to shouldn't it be ?? false?
  4. Oli Bartsch commented on patch set 1 10/12/21, 22:03

    ModuleLoader.php:194 Reply

    Null is the correct fallback value, in case we don't want to change behaviour (See: https://3v4l.org/Z4Glb). We recently had a regression because of exactly this kind of check.
  5. Benni Mack voted on patch set 1 V +1 CR +1 10/13/21, 08:27

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 10/13/21, 09:09

  7. Christian Kuhn merged patch set 2 10/13/21, 09:09