71601[BUGFIX] Fix undefined array key access in ModuleLoader
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 67
-
Oli Bartsch uploaded patch set 1 10/12/21, 19:51
-
core-ci voted on patch set 1 V +1 10/12/21, 20:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17992
-
Wouter Wolters commented on patch set 1 10/12/21, 21:41
-
Oli Bartsch commented on patch set 1 10/12/21, 22:03
ModuleLoader.php:194ReplyNull is the correct fallback value, in case we don't want to change behaviour (See: https://3v4l.org/Z4Glb). We recently had a regression because of exactly this kind of check. -
Benni Mack voted on patch set 1 V +1 CR +1 10/13/21, 08:27
-
Christian Kuhn voted on patch set 1 V +2 CR +2 10/13/21, 09:09
-
Christian Kuhn merged patch set 2 10/13/21, 09:09
ModuleLoader.php:194