Review main Merged

71604[BUGFIX] Fix undefined array key warning in TitleTagRenderingTest

Stefan Bürk CR +2 V +2 Easy +5 −5 updated 10/13/21, 10:09

Commit message

Test data array had not been consistent, thus throwing undefined
array access warnings.

This patch use null coalescing operator to fix these warnings.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Stefan Bürk uploaded patch set 1 10/12/21, 20:53

  2. core-ci voted on patch set 1 V +1 10/12/21, 21:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17995

  3. Oliver Klee voted on patch set 1 CR +1 10/12/21, 21:36

  4. Wouter Wolters voted on patch set 1 CR +1 10/12/21, 21:43

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 10/13/21, 09:33

  6. Benjamin Franzke voted on patch set 1 V +2 CR +2 10/13/21, 10:09

  7. Benjamin Franzke merged patch set 2 10/13/21, 10:09