Review main Merged

71608[BUGFIX] Restore "edit metadata" of translated files in FormEngine

Oli Bartsch CR +2 V +2 Easy +10 −8 updated 10/13/21, 12:00

Commit message

In case a files' metadata were translated in a L>0 language,
whenever the file is references in a record with this L>0
language, the inline controls show the "edit metadata"
button again.

This previously did not work, because the language field,
resolved by FormEngine, might not always be an array with
the language uid on [0]. Other FormEngine parts already
implement proper checks. So does the InlineRecordContainer
now.

Additionally, this also fixes an undefined array key access
warning and replaces the hardcoded "sys_language_uid"
field name, since this might be changed in TCA.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Oli Bartsch uploaded patch set 1 10/12/21, 21:54

  2. Oli Bartsch updated the commit message in patch set 2 10/12/21, 21:57

  3. core-ci voted on patch set 1 V +1 10/12/21, 22:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17999

  4. core-ci voted on patch set 2 V +1 10/12/21, 22:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18000

  5. Christian Kuhn voted on patch set 2 V +2 CR +2 10/13/21, 11:59

  6. Jochen Roth voted on patch set 2 V +1 CR +1 10/13/21, 11:59

  7. Christian Kuhn merged patch set 3 10/13/21, 12:00