Review main Merged

71609[BUGFIX] Use correct id for viewpage iframe

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 10/13/21, 08:16

Commit message

While migrating the viewpage JavaScript module
to TypeScript in #87704, an id was falsely renamed.

This is now fixed by using the correct id again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 10/12/21, 23:02

  2. core-ci voted on patch set 1 V +1 10/12/21, 23:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18002

  3. Josef Glatz voted on patch set 1 CR +1 10/13/21, 02:19

  4. Andreas Kienast voted on patch set 1 V +1 CR +1 10/13/21, 07:44

  5. Benni Mack voted on patch set 1 V +2 CR +2 10/13/21, 08:15

  6. Benni Mack merged patch set 2 10/13/21, 08:16