71610[BUGFIX] Ensure cyrilic work as regexp redirects capture group
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1116
-
Susi Moog uploaded patch set 1 10/13/21, 06:14
-
core-ci voted on patch set 1 V +1 10/13/21, 06:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18005
-
Stefan Bürk commented on patch set 1 CR -1 10/13/21, 09:06
See code comment. Besides this there are no tests in place for it. Will add tests when I have time for it (at the weekend) and test/verify if the first matching place should be adjusted to.RedirectService.php:376That's not the first place the regexp would be matched, that's done before. Should be checked if it have to be done there first. -
Stefan Bürk uploaded patch set 2 10/18/21, 15:46
-
Stefan Bürk updated the commit message in patch set 3 10/18/21, 15:59
-
Stefan Bürk updated the commit message in patch set 4 10/18/21, 16:00
-
core-ci voted on patch set 2 V +1 10/18/21, 16:05 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18280
-
core-ci voted on patch set 4 V +1 10/18/21, 16:17 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18282
-
core-ci voted on patch set 3 V +1 10/18/21, 16:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18281
-
Stefan Bürk updated the commit message in patch set 5 10/18/21, 17:00
-
Stefan Bürk commented on patch set 5 10/18/21, 17:12
Added tests and added another rawurldecode() needed, found during adding tests.RedirectService.php:376ReplyAdded here another rawurldecode() for the query part. -
Stefan Bürk wrote 10/18/21, 17:12
Removed reviewer Stefan Bürk. -
core-ci voted on patch set 5 V +1 10/18/21, 17:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18289
-
Jochen Roth voted on patch set 5 V +1 CR +1 10/19/21, 13:59
-
Christian Kuhn voted on patch set 5 V +2 CR +2 10/19/21, 14:00
-
Christian Kuhn merged patch set 6 10/19/21, 14:00