Review main Merged

71613[BUGFIX] Bump symfony/polyfill-php80 to ^1.23.1

Benjamin Franzke CR +2 V +2 Easy +4 −3 updated 10/13/21, 07:10

Commit message

Since #95466 str_contains() is used with `null`
instead of strings in a lot of cases throughout the core.
This causes TypeErrors with symfony/polyfill-php80 < 1.23.1
(nighty composer-min stage).

symfony/polyfill-php80 accounted for this case with v1.23.1,
therefore the minimum requirement is raised.
Also the missing requirement in EXT:core is added.

composer require symfony/polyfill-php80:^1.23.1
composer require --no-update -d typo3/sysext/core \
    symfony/polyfill-php80:^1.23.1
composer require --no-update -d typo3/sysext/form \
    symfony/polyfill-php80:^1.23.1

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 45

  1. Benjamin Franzke uploaded patch set 1 10/13/21, 06:43

  2. Andreas Kienast voted on patch set 1 CR +1 10/13/21, 06:49

  3. core-ci voted on patch set 1 V +1 10/13/21, 07:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18008

  4. Benni Mack voted on patch set 1 V +2 CR +2 10/13/21, 07:10

  5. Benni Mack merged patch set 2 10/13/21, 07:10