71616[BUGFIX] Fix undefined array key warnings in GraphicalFunctions
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Jochen Roth +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1517
-
Nikita Hovratov uploaded patch set 1 10/13/21, 10:08
-
Christian Kuhn voted on patch set 1 V +1 CR +1 10/13/21, 10:09
-
Benjamin Franzke commented on patch set 1 10/13/21, 10:16
-
Nikita Hovratov commented on patch set 1 10/13/21, 10:20
GraphicalFunctions.php:601ReplyNot catched by a test I guess. I can try to check the else branch by setting this "niceText" parameter. -
core-ci voted on patch set 1 V +1 10/13/21, 10:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18021
-
Nikita Hovratov uploaded patch set 2 10/13/21, 10:26
-
Nikita Hovratov commented on patch set 2 10/13/21, 10:27
GraphicalFunctions.php:601ReplyDone -
Christian Kuhn voted on patch set 2 V +1 CR +1 10/13/21, 10:38
-
core-ci voted on patch set 2 V +1 10/13/21, 10:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18024
-
Oliver Klee voted on patch set 2 CR +1 10/13/21, 11:07
-
Jochen Roth voted on patch set 2 V +1 CR +1 10/13/21, 12:29
-
Christian Kuhn voted on patch set 2 V +2 CR +2 10/13/21, 12:29
-
Christian Kuhn merged patch set 3 10/13/21, 12:29
-
Simon Schaufelberger commented on patch set 3 10/13/21, 16:06
GraphicalFunctions.php:478Should the default value not be "1,1"? I wanted to write a test for this case already to verify that. The docs don't mention a default value sadly.GraphicalFunctions.php:2061UnresolvedI would prefer the default value of "0,0" here like the docs say: https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/Gifbuilder/ObjectNames/Index.html#image instead of an empty string -
Nikita Hovratov commented on patch set 3 10/13/21, 17:22
GraphicalFunctions.php:478ReplyYes, you are right with both. Do you wanna fix it? -
Simon Schaufelberger commented on patch set 3 10/14/21, 15:24
GraphicalFunctions.php:478Replyyes, I will also provide a test case -
Nikita Hovratov commented on patch set 3 11/22/23, 21:47
GraphicalFunctions.php:478ReplyDone
GraphicalFunctions.php:601