Review main Merged

71619[BUGFIX] Avoid warning from optional HTTP_ACCEPT_LANGUAGE

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/13/21, 12:04

Commit message

HTTP header 'Accept-Language' may not be sent by clients,
the patch sanitizes access to $request HTTP_ACCEPT_LANGUAGE
using null coalescing operator.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/13/21, 10:54

  2. Oliver Klee voted on patch set 1 CR +1 10/13/21, 11:06

  3. core-ci voted on patch set 1 V +1 10/13/21, 11:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18027

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 10/13/21, 11:40

  5. Benni Mack voted on patch set 1 V +2 CR +2 10/13/21, 12:04

  6. Benni Mack merged patch set 2 10/13/21, 12:04