Review 10.4 Merged

71623[BUGFIX] Pad multibyte strings correctly

Georg Ringer CR +2 V +2 Normal +141 −2 updated 10/13/21, 12:47

Commit message

A new function StringUtility::multibyteStringPad() is
introduced to handle multibyte strings instead of
str_pad() which will not pad strings with multibyte
characters correctly.

The new function is now used for:

- Fluid ViewHelper format.padding
- TypoScript stdWrap.strPad

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 56

  1. Georg Ringer uploaded patch set 1 10/13/21, 12:26

  2. Georg Ringer commented on patch set 1 10/13/21, 12:26

    This change is ready for review.
  3. Simon Schaufelberger commented on patch set 1 V +1 CR +1 10/13/21, 12:42

    tested and works!
  4. core-ci voted on patch set 1 V +1 10/13/21, 12:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18040

  5. Georg Ringer voted on patch set 1 V +2 CR +2 10/13/21, 12:47

  6. Georg Ringer merged patch set 2 10/13/21, 12:47