Review 10.4 Merged

71624[BUGFIX] Avoid warning when eID is given as array

Christian Kuhn CR +2 V +2 Easy +14 −2 updated 10/13/21, 12:56

Commit message

Calling https://www.example.com/?eID[]= results in $eID being an array
which triggers an 'illegal offset' warning and an entry in the error log.

Reject these invalid queries with a 400 response.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Sebastian Michaelsen +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Sebastian Michaelsen +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/13/21, 12:28

  2. Sebastian Michaelsen voted on patch set 1 V +1 CR +1 10/13/21, 12:29

  3. Benjamin Franzke voted on patch set 1 V +1 CR +1 10/13/21, 12:43

  4. core-ci voted on patch set 1 V +1 10/13/21, 12:49 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18042

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/13/21, 12:56

  6. Christian Kuhn merged patch set 2 10/13/21, 12:56