Review main Merged

71627[BUGFIX] Prevent exceptions for new user accounts

Oli Bartsch CR +2 V +2 Easy +7 −2 updated 10/13/21, 19:18

Commit message

In case new user accounts are not properly set up
and the user tries to login, some toolbar related
components led to exceptions.

This is now fixed by taking the current user status
into account. In detail, the workspace title is only
checked, if the user has a proper workspace defined
and the user module children are only checked if
the user has access to the main module.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • Jonas Eberle +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 10/13/21, 14:36

  2. Jonas Eberle commented on patch set 1 V +1 10/13/21, 14:51

    Thanks!
  3. core-ci voted on patch set 1 V +1 10/13/21, 14:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18053

  4. Jochen Roth voted on patch set 1 V +1 CR +1 10/13/21, 19:07

  5. Benni Mack voted on patch set 1 V +2 CR +2 10/13/21, 19:18

  6. Benni Mack merged patch set 2 10/13/21, 19:18