Review main Merged

71632[BUGFIX] Avoid improper method call in PageRepositoryTest

Christian Kuhn CR +2 V +2 Easy +9 −4 updated 10/13/21, 19:02

Commit message

Some PageRepositoryTest tests call getMenu() with a
restricted set of select fields as second argument.

Running this test without error suppression reveals
the code accesses db fields like 'doktype' which are
not fetched with a restricted field list.

The patch changes the test method calls to not restrict
the field list to fix the test, and adds a @todo in
PageRepository to review the $fields argument with a
future patch so the code does not rely on a possibly
incomplete list of fields anymore.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/13/21, 17:18

  2. core-ci voted on patch set 1 V +1 10/13/21, 17:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18065

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 10/13/21, 17:41

  4. Jochen Roth voted on patch set 1 V +1 CR +1 10/13/21, 18:15

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/13/21, 19:02

  6. Christian Kuhn merged patch set 2 10/13/21, 19:02