Review main Merged

71635[BUGFIX] Avoid warning in ResourceStorage

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/13/21, 19:06

Commit message

ResourceStorage->getUniqueName() is used to return a
unique and sanitized file or folder name. It uses
pathinfo() on the given name. pathinfo() returns the
'file ending' (like 'txt') as 'extension' array key. This
array key is not set when a file without 'extension' is
given (like "foo"). This leads to a warning getUniqueName().

The patch sanitizes access to 'extension' using null
coalescing operator.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Wouter Wolters +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Christian Kuhn uploaded patch set 1 10/13/21, 18:11

  2. core-ci voted on patch set 1 V +1 10/13/21, 18:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18068

  3. Stefan Bürk voted on patch set 1 CR +1 10/13/21, 18:36

  4. Jochen Roth voted on patch set 1 V +1 CR +1 10/13/21, 18:42

  5. Stefan Bürk voted on patch set 1 V +1 10/13/21, 18:44

  6. Wouter Wolters voted on patch set 1 V +1 CR +1 10/13/21, 18:47

  7. Christian Kuhn voted on patch set 1 V +2 CR +2 10/13/21, 19:06

  8. Christian Kuhn merged patch set 2 10/13/21, 19:06