Review main Merged

71636[TASK] Avoid deprecated code in cache:flush TCA loading

Benjamin Franzke CR +2 V +2 Easy +9 −6 updated 10/13/21, 18:56

Commit message

With the deprecation of CacheManager usage during TCA/ext_tables
loading in #94979, the console command cache:flush needs to be
adapted to avoid CacheManager when loading TCA.

BootService is therefore adapted to pass the 'core' cache instance
to the respective TCA methods directly, avoiding CacheManager
usage inside ExtensionManagementUtility.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 810

  1. Benjamin Franzke uploaded patch set 1 10/13/21, 18:21

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 10/13/21, 18:32

  3. core-ci voted on patch set 1 V +1 10/13/21, 18:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18069

  4. Christian Kuhn commented on patch set 1 CR -1 10/13/21, 18:38

    sorting out details
  5. Benjamin Franzke updated the commit message in patch set 2 10/13/21, 18:41

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 10/13/21, 18:50

  7. Stefan Bürk voted on patch set 2 V +1 CR +1 10/13/21, 18:51

  8. core-ci voted on patch set 2 V +1 10/13/21, 18:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18070

  9. Benjamin Franzke voted on patch set 2 V +2 CR +2 10/13/21, 18:56

  10. Benjamin Franzke merged patch set 3 10/13/21, 18:56