Review main Merged

71638[BUGFIX] Fix dashboard drag and drop handler

waldhacker CR +2 V +2 Easy +2 −4 updated 10/14/21, 06:16

Commit message

Migrate the muuri.js option `dragStartPredicate.handle`
to `dragHandle`, preventing the draggable area to be on
the whole widget, instead of the corresponding button.

Review

  • Code review CR +2 Done
    • waldhacker +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • waldhacker +2
    • Oli Bartsch +1
    • Benni Mack +1

Issues 1

Files 2

Review log 67

  1. waldhacker uploaded patch set 1 10/13/21, 21:04

  2. core-ci voted on patch set 1 V +1 10/13/21, 21:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18077

  3. Oli Bartsch updated the commit message in patch set 2 10/13/21, 22:48

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 10/13/21, 22:49

  5. Benni Mack voted on patch set 2 V +1 CR +1 10/14/21, 06:10

  6. waldhacker voted on patch set 2 V +2 CR +2 10/14/21, 06:16

  7. waldhacker merged patch set 3 10/14/21, 06:16