Review main Merged

71652[BUGFIX] Indexed Search Lexer checks for words instead of letters again

Benni Mack CR +2 V +2 Easy +15 −12 updated 10/14/21, 08:22

Commit message

Due to a regression introduced in PHP8 bugfixes
(see https://review.typo3.org/c/Packages/TYPO3.CMS/+/69819)
this change did not set the $cType variable
anymore, making all letters a single word
in indexed search.

This change not only fixes the issue but
also uses constants to understand the contents
better.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Wouter Wolters +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 10/14/21, 06:37

  2. core-ci voted on patch set 1 V +1 10/14/21, 06:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18084

  3. Jochen Roth voted on patch set 1 V +1 CR +1 10/14/21, 07:57

  4. Wouter Wolters voted on patch set 1 CR +1 10/14/21, 08:04

  5. Christian Kuhn voted on patch set 1 CR +1 10/14/21, 08:11

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 10/14/21, 08:22

  7. Oli Bartsch merged patch set 2 10/14/21, 08:22