Review main Merged

71653[BUGFIX] Avoid improper setup in ext:backend controller tests

Stefan Bürk CR +2 V +2 Normal +124 −74 updated 10/14/21, 09:18

Commit message

Controller tests for ext:backend setup server requests
to simulate frontend calls, thus omitting the default
frontend setup process.

The test controller use PageRenderer which uses
$GLOBALS['TYPO3_REQUEST'] as fallback, but this is not
set, leading to undefined array key warnings.

The patch changes affected test classes to set up
requests $GLOBALS['TYPO3_REQUEST'].

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 68

  1. Stefan Bürk uploaded patch set 1 10/14/21, 07:00

  2. core-ci voted on patch set 1 V +1 10/14/21, 07:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18085

  3. Christian Kuhn uploaded patch set 2 10/14/21, 08:57

  4. core-ci voted on patch set 2 V +1 10/14/21, 09:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18091

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 10/14/21, 09:14

  6. Jochen Roth voted on patch set 2 V +1 CR +1 10/14/21, 09:18

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 10/14/21, 09:18

  8. Christian Kuhn merged patch set 3 10/14/21, 09:18