Review main Merged

71692[BUGFIX] Fix PHP8 warning in NumberWithIconWidget

Chris Müller CR +2 V +2 Easy +3 −3 updated 10/14/21, 18:02

Commit message

The subtitle can be considered optional, and if not set a PHP8
warning is raised. Additionally, the other two options now also
have a fallback to avoid warnings, also when it does not make
sense to omit them in custom widgets.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Chris Müller uploaded patch set 1 10/14/21, 09:24

  2. Christian Kuhn updated the commit message in patch set 2 10/14/21, 10:28

  3. Oliver Klee voted on patch set 2 CR +1 10/14/21, 10:33

  4. core-ci voted on patch set 2 V +1 10/14/21, 10:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18097

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 10/14/21, 18:01

  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 10/14/21, 18:02

  7. Anja Leichsenring merged patch set 3 10/14/21, 18:02