Review main Merged

71712[BUGFIX] Fix session warning from MFA controller tests

Christian Kuhn CR +2 V +2 Easy +28 −0 updated 10/14/21, 10:33

Commit message

Some MFA controller tests trigger backendUser->logOff() which
destroys the backend user session. This backend user is also
a system maintainer by default. This leads to the system
maintainer session being initialized twice - once from
testing-framework, once from system under test. The destroy
operation then fails with "Session save path cannot be
changed after headers have already been sent". To suppress this,
we simply drop the system maintainer flag from this backend user.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Christian Kuhn uploaded patch set 1 10/14/21, 09:56

  2. core-ci voted on patch set 1 V -1 10/14/21, 10:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18093

  3. Christian Kuhn uploaded patch set 2 10/14/21, 10:01

  4. Georg Ringer updated the commit message in patch set 3 10/14/21, 10:04

  5. Stefan Bürk voted on patch set 3 V +1 CR +1 10/14/21, 10:13

  6. core-ci voted on patch set 2 V +1 10/14/21, 10:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18094

  7. core-ci voted on patch set 3 V +1 10/14/21, 10:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18095

  8. Oli Bartsch voted on patch set 3 V +2 CR +2 10/14/21, 10:33

  9. Oli Bartsch merged patch set 4 10/14/21, 10:33