Review main Merged

71752[BUGFIX] Avoid dangling error handler registrations in tests

Christian Kuhn CR +2 V +2 Easy +11 −1 updated 10/14/21, 13:58

Commit message

The functional ErrorHandlerTest uses set_error_handler()
to register test subjects. These need to be dropped
afterwards to not end up with additional error handlers
in other tests which may suppress errors we'd see otherwise.

The testing-framework will soon have a check to avoid
this scenario in the future, so this bug can't happen
again.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/14/21, 13:24

  2. core-ci voted on patch set 1 V +1 10/14/21, 13:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18103

  3. Jochen Roth voted on patch set 1 V +1 CR +1 10/14/21, 13:47

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 10/14/21, 13:56

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/14/21, 13:58

  6. Christian Kuhn merged patch set 2 10/14/21, 13:58