71775[BUGFIX] Consider language in redirects:checkintegrity
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Sybille Peters +1
-
Verified V +2 Done
- Benni Mack +2
- Sybille Peters +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/redirects/Classes/Service/IntegrityService.php2+93 −55
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/IntegrityServiceTest_sourcePathWithMatchingSlugInLocalizedPageIsNotReportedAsConflict.xmlnew+38 −0
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/LocalizedPages.csv+10 −9
- typo3/sysext/redirects/Tests/Functional/Service/Fixtures/sys_redirect.csv+2 −0
- typo3/sysext/redirects/Tests/Functional/Service/IntegrityServiceTest.php+52 −2
Review log 3249
Show 1624 earlier messages
-
Sybille Peters uploaded patch set 1 10/14/21, 16:37
-
Sybille Peters marked it work in progress 10/14/21, 16:38
-
core-ci voted on patch set 1 V -1 10/14/21, 16:41 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18111
-
Sybille Peters uploaded patch set 2 10/14/21, 16:43
-
core-ci voted on patch set 2 V -1 10/14/21, 16:59 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18112
-
Sybille Peters uploaded patch set 3 10/14/21, 17:39
-
Sybille Peters marked it ready for review 10/14/21, 17:40
-
Sybille Peters uploaded patch set 4 10/14/21, 17:41
-
core-ci voted on patch set 3 V -1 10/14/21, 17:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18115
-
core-ci voted on patch set 4 V -1 10/14/21, 18:00 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18116
-
Sybille Peters rebased onto patch set 5 10/14/21, 18:18
-
core-ci voted on patch set 5 V -1 10/14/21, 18:43 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18123
-
Sybille Peters uploaded patch set 6 10/14/21, 19:09
-
Sybille Peters updated the commit message in patch set 7 10/14/21, 19:16
-
core-ci voted on patch set 6 V +1 10/14/21, 19:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18129
-
core-ci voted on patch set 7 V +1 10/14/21, 19:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18130
-
Benni Mack updated the commit message in patch set 8 10/15/21, 08:16
-
Benni Mack voted on patch set 8 CR +1 10/15/21, 08:17
-
core-ci voted on patch set 8 V +1 10/15/21, 08:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18146
-
Sybille Peters commented on patch set 8 V -1 10/15/21, 13:50
I backported patch to v10 and tested on copy of my site. I get infinite calling of subfunction getSlugsOfSubPages(). I should check out first what is the reason and if this can happen on v11 too. -
Stefan Bürk commented on patch set 8 CR -1 10/15/21, 19:53
Reply
Do you get an error message in some kind ? Or are you sure it is an infinit recursion ?IntegrityService.php:155As method is bound to one language now, we should at least add a condition to narrow down page languguas to 0 (because of traversion) and additional the language '$languageId'. Otherwise in a installation with a lot of languagees it will retrieve for each language all language kinds, to filter out some lines below only the current language. In this logic we only need to retrieve at maximum 2 page language versions, default and selected language. -
Sybille Peters commented on patch set 8 10/15/21, 20:54
Reply
yes. However, I "backported" to v10, meaning I had to patch some stuff because it did not work from scratch. I cannot reproduce this problem with "master". We should probably just make sure it can't happen. I assume some other problem. Uncaught TYPO3 Exception Maximum function nesting level of '2000' reached, aborting! thrown in file vendor/doctrine/dbal/lib/Doctrine/DBAL/Query/Expression/CompositeExpression.php in line 93 --- in the TYPO3 log: multiple entries of: 2.8888 74596120 1958. TYPO3\\CMS\\Redirects\\Service\\IntegrityService->getSlugsOfSubPages() typo3/sysext/redirects/Classes/Service/IntegrityService.php:166 2.8904 74630720 1959. TYPO3\\CMS\\Redirects\\Service\\IntegrityService->getSlugsOfSubPages() typo3/sysext/redirects/Classes/Service/IntegrityService.php:166 2.8919 74665320 1960. TYPO3\\CMS\\Redirects\\Service\\IntegrityService->getSlugsOfSubPages() typo3/sysext/redirects/Classes/Service/IntegrityService.php:166 -
Sybille Peters uploaded patch set 9 10/15/21, 21:14
-
Sybille Peters commented on patch set 9 V -1 10/15/21, 21:15
We are still optimizing solution ...
-
Sybille Peters commented on patch set 9 10/15/21, 21:15
IntegrityService.php:155ReplyDone -
core-ci voted on patch set 9 V -1 10/15/21, 21:19 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18211
-
Sybille Peters uploaded patch set 10 10/15/21, 21:21
-
core-ci voted on patch set 10 V +1 10/15/21, 21:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18212
-
Sybille Peters updated the commit message in patch set 11 10/16/21, 09:34
-
core-ci voted on patch set 11 V +1 10/16/21, 09:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18222
-
Stefan Bürk commented on patch set 11 CR -1 10/16/21, 10:30
on it -
Stefan Bürk uploaded patch set 12 10/16/21, 14:39
-
Stefan Bürk commented on patch set 12 CR -1 10/16/21, 14:40
Forgot something. Will repush. -
core-ci voted on patch set 12 V -1 10/16/21, 14:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18225
-
Stefan Bürk uploaded patch set 13 10/16/21, 16:50
-
core-ci voted on patch set 13 V -1 10/16/21, 17:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18226
-
Stefan Bürk uploaded patch set 14 10/16/21, 17:16
-
core-ci voted on patch set 14 V +1 10/16/21, 17:33 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18227
-
Stefan Bürk uploaded patch set 15 10/16/21, 17:53
-
core-ci voted on patch set 15 V +1 10/16/21, 18:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18228
-
Sybille Peters voted on patch set 15 V +1 10/16/21, 18:13
-
Sybille Peters updated the commit message in patch set 16 10/17/21, 06:33
-
core-ci voted on patch set 16 V +1 10/17/21, 06:51 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18235
-
Sybille Peters commented on patch set 16 V +1 CR +1 10/17/21, 06:55
Reply
DoneMy last 2 patches only changed some texts in commit message and comment. Final code was adapted by Stefan - thank you very much :) -
Sybille Peters uploaded patch set 17 10/17/21, 06:58
-
Sybille Peters voted on patch set 17 V +1 CR +1 10/17/21, 06:59
-
core-ci voted on patch set 17 V +1 10/17/21, 07:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18236
-
Benni Mack voted on patch set 17 V +2 CR +2 10/21/21, 10:26
-
Benni Mack merged patch set 18 10/21/21, 10:26