Review main Merged

71793[TASK] Have notice and warning free functional tests

Christian Kuhn CR +2 V +2 Easy +14 −8 updated 10/15/21, 06:50

Commit message

This new testing-framework version brings a feature
to let functional test fail if warnings or notices
or deprecations are raised.

This is achieved by not activating the default core
error handler in funcitional tests and bubbling up
errors into native phpunit error handler.

The feature is enabled by a constant defined in
FunctionalTests.xml.

From now on, we let tests that raise warnings or
notices fail, while deprecations are accepted.
Another patch will then extract tests that actively
test deprecated code to an own test suite and will
activate test fails for raised deprecations, too.

composer req --dev typo3/testing-framework:^6.12.0

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • Wouter Wolters +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1219

  1. Christian Kuhn uploaded patch set 1 10/14/21, 18:02

  2. Christian Kuhn uploaded patch set 2 10/14/21, 18:03

  3. core-ci voted on patch set 2 V +1 10/14/21, 18:24 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18118

  4. core-ci voted on patch set 1 V +1 10/14/21, 18:28 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18117

  5. Christian Kuhn uploaded patch set 3 10/14/21, 18:29

  6. Christian Kuhn uploaded patch set 4 10/14/21, 18:42

  7. core-ci voted on patch set 3 V -1 10/14/21, 18:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18124

  8. core-ci voted on patch set 4 V -1 10/14/21, 19:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18126

  9. Christian Kuhn rebased onto patch set 5 10/14/21, 19:19

  10. core-ci voted on patch set 5 V +1 10/14/21, 19:35 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18131

  11. core-ci commented on patch set 5 10/14/21, 20:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18133

  12. Christian Kuhn uploaded patch set 6 10/14/21, 20:51

  13. Markus Klein voted on patch set 6 CR +1 10/14/21, 20:55

  14. Christian Kuhn commented on patch set 6 10/14/21, 20:56

    note: this had a green run as nightly already.
  15. Wouter Wolters voted on patch set 6 CR +1 10/14/21, 20:57

  16. core-ci voted on patch set 6 V +1 10/14/21, 21:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18138

  17. Stefan Bürk voted on patch set 6 V +1 CR +1 10/14/21, 21:45

  18. Andreas Kienast voted on patch set 6 V +2 CR +2 10/15/21, 06:50

  19. Andreas Kienast merged patch set 7 10/15/21, 06:50