Review main Merged

71795[BUGFIX] Fix #modulemenu collapsed state on Firefox

Jonas Eberle CR +2 V +2 Easy +2 −1 updated 11/04/21, 16:22

Commit message

This fixes cut modulemenu icons on Firefox when scrollbars are shown.
It has been fixed before, but since then seemingly unrelated changes had
the problem resurface.

This time we set a min-width: for these links to prevent them from
shrinking even if the #modulemenu around them decides to give some space
to the scrollbar.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 1115

  1. Jonas Eberle uploaded patch set 1 10/14/21, 18:08

  2. Jonas Eberle updated the commit message in patch set 2 10/14/21, 18:09

  3. core-ci voted on patch set 2 V +1 10/14/21, 18:37 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18122

  4. core-ci voted on patch set 1 V +1 10/14/21, 18:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18121

  5. Jonas Eberle updated the commit message in patch set 3 10/15/21, 08:54

  6. core-ci voted on patch set 3 V +1 10/15/21, 09:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18148

  7. Riccardo De Contardi commented on patch set 3 10/17/21, 08:55

    The situation gets better after applying the patch, but some differerence between browsers still remains - I've updated issue https://forge.typo3.org/issues/95656
  8. Anja Leichsenring uploaded patch set 4 11/04/21, 14:42

  9. Anja Leichsenring voted on patch set 4 V +1 CR +1 11/04/21, 14:45

  10. core-ci voted on patch set 4 V +1 11/04/21, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18893

  11. Oli Bartsch commented on patch set 4 11/04/21, 14:57

    _modulemenu.scss:32

    Can we fix this with a generic flexbox approach instead of assigning a fixed width? You may also want to check https://review.typo3.org/c/Packages/TYPO3.CMS/+/68841, which is also dealing with this topic.
  12. Jonas Eberle commented on patch set 4 11/04/21, 15:14

    _modulemenu.scss:32 Reply Unresolved

    This is not perfect (as shown on Riccardo's screenshots in forge). It just fixes the immediate problem but does not manage to provide a consistent width for all browsers. I have not managed to track down/influence the root problem of this browser-inconsistency with scrollbars. I like the other patch which deals with visual appearance and hides scrollbars when unused but it does not fix the layouting problem we have here.
  13. Christian Kuhn voted on patch set 4 V +1 11/04/21, 16:19

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 11/04/21, 16:22

  15. Christian Kuhn merged patch set 5 11/04/21, 16:22