71797[BUGFIX] Do not log page access failures
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Torben Hansen +1
- Christoph Lehmann +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2935
Show 810 earlier messages
-
Markus Klein uploaded patch set 1 10/14/21, 19:33
-
Benni Mack commented on patch set 1 CR -1 10/14/21, 19:39
$message is still needed a few lines further down -
Markus Klein uploaded patch set 2 10/14/21, 19:52
-
Markus Klein commented on patch set 2 10/14/21, 19:52
Reply
gnaaa.... sorry -
core-ci voted on patch set 1 V -1 10/14/21, 19:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18132
-
core-ci voted on patch set 2 V +1 10/14/21, 20:09 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18135
-
Benjamin Franzke voted on patch set 2 V +1 CR +1 10/14/21, 20:20
-
Christoph Lehmann commented on patch set 2 10/14/21, 20:23
Thanks for working on this!TypoScriptFrontendController.php:1212First of all: Thanks for working on this! Can we drop this one too?TypoScriptFrontendController.php:2028For my understanding this is reasonable too, since one can hide the default language variant of a page.... So drop it? -
Markus Klein commented on patch set 2 10/14/21, 20:31
TypoScriptFrontendController.php:1212ReplyYes, I think this can/should go as wellTypoScriptFrontendController.php:2028ReplyAgree. So the whole logPageAccessFailure() function has 1 usage left then -
Benjamin Franzke commented on patch set 2 10/14/21, 20:36
TypoScriptFrontendController.php:1212ReplyHm, I tend to agree, but it seems this block needs some more refactoring: The error page is generated using internalErrorAction(), seems that should also be changed to accessDeniedAction().TypoScriptFrontendController.php:2028ReplyAck, sounds reasonable to me.
-
Markus Klein commented on patch set 2 10/14/21, 20:43
TypoScriptFrontendController.php:1212ReplyNot sure. accessDenied means 403 status, which indirectly reveals that the requested page indeed exists. But hidden/start/end should actually behave like the page does not exist (404) -
Christoph Lehmann commented on patch set 2 10/14/21, 20:45
TypoScriptFrontendController.php:1212ReplyI totally agree with this, it should be a 404 when a page is hidden/start/end -
Markus Klein uploaded patch set 3 10/15/21, 07:09
-
Markus Klein commented on patch set 3 10/15/21, 07:10
TypoScriptFrontendController.php:1212Replyremoved this lineTypoScriptFrontendController.php:2028ReplyDone -
Christoph Lehmann voted on patch set 3 V +1 CR +1 10/15/21, 07:12
-
Benni Mack voted on patch set 3 CR +1 10/15/21, 07:25
-
core-ci voted on patch set 3 V +1 10/15/21, 07:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18143
-
Benni Mack uploaded patch set 4 10/15/21, 07:53
-
Benjamin Franzke voted on patch set 4 CR +1 10/15/21, 07:56
-
Markus Klein commented on patch set 4 CR -1 10/15/21, 07:58
talking to Benni -
Benjamin Franzke voted on patch set 4 V +1 10/15/21, 08:04
-
core-ci voted on patch set 4 V +1 10/15/21, 08:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18145
-
Benjamin Franzke commented on patch set 4 10/15/21, 08:08
TypoScriptFrontendController.php:1212Reply> Not sure. accessDenied means 403 status, which indirectly reveals that the requested page indeed exists. But hidden/start/end should actually behave like the page does not exist (404) I agree in general. But I could only trigger this using a "Backend User Section" on the root level. Is the comment > // Checking for include section regarding the hidden/starttime/endtime/fe_user (that is access control of a whole subbranch! correct at all? I mean checkRootlineForIncludeSection doesn't seem to handle hidden/starttime/endtime/fe_user. -
Benni Mack commented on patch set 4 10/15/21, 08:13
TypoScriptFrontendController.php:1212ReplyYes. checkPagerecordForIncludeSection does this for you -
Benni Mack commented on patch set 4 10/15/21, 08:19
let's go back to PS3 and tackle the accessDenied topic separately (probably master-only then) -
Benni Mack uploaded patch set 5 10/15/21, 08:19
-
core-ci voted on patch set 5 V +1 10/15/21, 08:36 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18147
-
Benjamin Franzke uploaded patch set 6 10/15/21, 10:37
-
Benjamin Franzke commented on patch set 6 10/15/21, 10:37
TypoScriptFrontendController.php:1212ReplyLet's normalize to pageNotFoundAction for now. -
core-ci voted on patch set 6 V +1 10/15/21, 10:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18157
-
Christoph Lehmann voted on patch set 6 CR +1 10/15/21, 11:00
-
Torben Hansen voted on patch set 6 CR +1 10/15/21, 12:28
-
Benni Mack voted on patch set 6 V +1 CR +1 10/15/21, 12:50
-
Benjamin Franzke voted on patch set 6 V +2 CR +2 10/15/21, 19:29
-
Benjamin Franzke merged patch set 7 10/15/21, 19:29