Review main Merged

71798[BUGFIX] Fix overlapping FormEngine fields

Nikita Hovratov CR +2 V +2 Normal +88 −75 updated 11/04/21, 12:20

Commit message

Because of normal selectSingle fields having the css property
"width: auto", very long text forces those fields to span
the whole width of the text.

To fix this problem, the entire table layout has to fall.
FormEngine fields have now a solid grid layout. This
allows us more control over the layout. With this in place
the fix is pretty straight forward: "overflow: hidden"
for the wrapping div of the select field.

In addition, some cleanup has been done in GroupElement:
Empty aside divs are no longer rendered.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1014

  1. Nikita Hovratov uploaded patch set 1 10/14/21, 19:39

  2. core-ci voted on patch set 1 V -1 10/14/21, 19:56 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18134

  3. Nikita Hovratov uploaded patch set 2 10/14/21, 20:15

  4. core-ci voted on patch set 2 V +1 10/14/21, 20:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18136

  5. Benni Mack commented on patch set 2 10/15/21, 07:35

    Please only target v11 (as we use flexbox there as much as possible)
  6. Nikita Hovratov updated the commit message in patch set 3 10/15/21, 07:40

  7. core-ci voted on patch set 3 V +1 10/15/21, 07:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18144

  8. Oli Bartsch voted on patch set 3 V +1 11/02/21, 10:15

  9. Anja Leichsenring voted on patch set 3 V +1 CR +1 11/03/21, 12:52

  10. Anja Leichsenring uploaded patch set 4 11/04/21, 11:36

  11. Anja Leichsenring voted on patch set 4 V +1 CR +1 11/04/21, 11:37

  12. core-ci voted on patch set 4 V +1 11/04/21, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18870

  13. Oli Bartsch voted on patch set 4 V +2 CR +2 11/04/21, 12:20

  14. Oli Bartsch merged patch set 5 11/04/21, 12:20