71799[BUGFIX] Fix cache clearing when publishing from workspace
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Guido Schmechel +1
- Wouter Wolters +1
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1011
-
Benjamin Franzke uploaded patch set 1 10/15/21, 07:04
-
Benjamin Franzke updated the commit message in patch set 2 10/15/21, 07:05
-
Benjamin Franzke commented on patch set 2 10/15/21, 07:08
Note: This is needed due to https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699/46/typo3/sysext/core/Classes/DataHandling/DataHandler.php#7924 And the additional query is added to preserve the previous behaviour that could simply check for pid >= 0, which is no longer possible as PID isn't transformed to -1: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61699/46/typo3/sysext/core/Classes/DataHandling/DataHandler.php#8025 -
core-ci voted on patch set 2 V +1 10/15/21, 07:21 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18142
-
Nikita Hovratov voted on patch set 2 V +1 CR +1 10/18/21, 07:53
-
Guido Schmechel voted on patch set 2 CR +1 10/18/21, 08:03
-
Wouter Wolters voted on patch set 2 CR +1 10/19/21, 21:10
-
Benni Mack commented on patch set 2 10/20/21, 15:34
DataHandler.php:8581Unresolvedone would need to check if this is a NEW_PLACEHOLDER (t3ver_state=1), if this is a new placeholder, then clear cache would be allowed as well. -
Benni Mack commented on patch set 2 V +1 CR +1 10/21/21, 14:38
Change is "Ok" for the time being. let's do this. -
Benjamin Franzke voted on patch set 2 V +2 CR +2 11/04/21, 06:43
-
Benjamin Franzke merged patch set 3 11/04/21, 06:43