Review main Merged

71800[BUGFIX] Avoid php warnings in Indexed Search Repository and Controlller

Benni Mack CR +2 V +2 Normal +57 −72 updated 10/17/21, 20:41

Commit message

This change reduces the amount of invalid PHP code
for PHP 8.0 and removes some unused functionality,
also uses proper casting where necessary.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1115

  1. Benni Mack uploaded patch set 1 10/15/21, 09:01

  2. Benni Mack commented on patch set 2 10/15/21, 09:17

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V +1 10/15/21, 09:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18149

  4. Jonas Eberle commented on patch set 2 V +1 10/15/21, 09:34

    Thank you. One step further :) I am now getting a new error in SearchController: Undefined array key "70092e93746599a96aad49c1c48918b7" in /var/www/html/typo3/sysext/indexed_search/Classes/Controller/SearchController.php line 392 at TYPO3\CMS\IndexedSearch\Controller\SearchController->compileResultRow(... in /var/www/html/typo3/sysext/indexed_search/Classes/Controller/SearchController.php line 353 at TYPO3\CMS\IndexedSearch\Controller\SearchController->getDisplayResults(... ... Shall I add a new ticket?
  5. core-ci voted on patch set 2 V +1 10/15/21, 09:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18151

  6. Jonas Eberle uploaded patch set 3 10/15/21, 11:48

  7. core-ci voted on patch set 3 V +1 10/15/21, 12:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18175

  8. Christian Kuhn commented on patch set 3 10/17/21, 20:22

    SearchController.php:475

    needs parenthesis.
  9. Christian Kuhn uploaded patch set 4 10/17/21, 20:28

  10. Christian Kuhn commented on patch set 4 10/17/21, 20:29

    SearchController.php:475 Reply

    Done
  11. Christian Kuhn commented on patch set 4 10/17/21, 20:30

    Reply

    yes.
  12. Stefan Bürk commented on patch set 4 V +1 CR +1 10/17/21, 20:31

    Reply

    yes.
  13. core-ci voted on patch set 4 V +1 10/17/21, 20:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18267

  14. Christian Kuhn voted on patch set 4 V +2 CR +2 10/17/21, 20:41

  15. Christian Kuhn merged patch set 5 10/17/21, 20:41