71800[BUGFIX] Avoid php warnings in Indexed Search Repository and Controlller
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1115
-
Benni Mack uploaded patch set 1 10/15/21, 09:01
-
Benni Mack commented on patch set 2 10/15/21, 09:17
Published edit on patch set 1. -
core-ci voted on patch set 1 V +1 10/15/21, 09:23 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18149
-
Jonas Eberle commented on patch set 2 V +1 10/15/21, 09:34
Thank you. One step further :) I am now getting a new error in SearchController: Undefined array key "70092e93746599a96aad49c1c48918b7" in /var/www/html/typo3/sysext/indexed_search/Classes/Controller/SearchController.php line 392 at TYPO3\CMS\IndexedSearch\Controller\SearchController->compileResultRow(... in /var/www/html/typo3/sysext/indexed_search/Classes/Controller/SearchController.php line 353 at TYPO3\CMS\IndexedSearch\Controller\SearchController->getDisplayResults(... ... Shall I add a new ticket? -
core-ci voted on patch set 2 V +1 10/15/21, 09:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18151
-
Jonas Eberle uploaded patch set 3 10/15/21, 11:48
-
core-ci voted on patch set 3 V +1 10/15/21, 12:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18175
-
Christian Kuhn commented on patch set 3 10/17/21, 20:22
SearchController.php:475needs parenthesis. -
Christian Kuhn uploaded patch set 4 10/17/21, 20:28
-
Christian Kuhn commented on patch set 4 10/17/21, 20:29
SearchController.php:475ReplyDone -
Christian Kuhn commented on patch set 4 10/17/21, 20:30
Reply
yes. -
Stefan Bürk commented on patch set 4 V +1 CR +1 10/17/21, 20:31
Reply
yes. -
core-ci voted on patch set 4 V +1 10/17/21, 20:40 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18267
-
Christian Kuhn voted on patch set 4 V +2 CR +2 10/17/21, 20:41
-
Christian Kuhn merged patch set 5 10/17/21, 20:41