71802[BUGFIX] Use the same identifier in configuration and wizard class
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Guido Schmechel +1
- Mathias Brodala +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1012
-
Helmut Hummel uploaded patch set 1 10/15/21, 09:53
-
Mathias Brodala commented on patch set 1 10/15/21, 10:05
Can you add an Important.rst that this will lead to these 2 wizards being executed again and this is expected? Technically this won't do any harm since the wizards check if they need execution anyways. Still this could be unexpected and should have a notice. -
core-ci voted on patch set 1 V +1 10/15/21, 10:07 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18154
-
Helmut Hummel uploaded patch set 2 10/15/21, 10:27
-
core-ci voted on patch set 2 V +1 10/15/21, 10:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18155
-
Helmut Hummel commented on patch set 2 10/16/21, 00:01
Reply
Thanks for your review. Two wizards? I'm actually only counting one so far. And how do you come to the conclusion that anything will be "executed again" after the proposed change? Wizards are marked done in the registry by class name, not by identifier. No class name is changed here. Just to make the current and fixed state clear: Current state is that this wizard can't be executed from cli. Neither with TYPO3 Console, nor with the core cli, nor the web ui, due to an exception being thrown. This means, except for new v11 installations, no registries can exist, that marked this wizard as executed. Fixed state will allow execution of this wizard. As far as I can tell nothing will be executed in excess and even if it would be, the worst case would be that ONE DB select query would be executed in addition. Not sure, but I'd say nothing of the above would need to be explicitly helpful to be documented, except through a commit message in a change log. I might be completely mistaken though. If this is the case, I'm happy to take action. -
Mathias Brodala commented on patch set 2 CR +1 10/18/21, 07:00
Reply
Hm, I could have sworn that there where two wizard identifiers updated at the time I left my review. Gerrit disagrees so I must have misread the change. And you are right, the class name is stored in the registry, not the identifier, so this is indeed a no-brainer. So thanks for having another look at this. -
Guido Schmechel voted on patch set 2 CR +1 10/18/21, 08:04
-
Jochen Roth voted on patch set 2 V +1 CR +1 10/19/21, 14:38
-
Christian Kuhn voted on patch set 2 V +2 CR +2 10/19/21, 14:40
-
Christian Kuhn merged patch set 3 10/19/21, 14:40
-
Christian Kuhn commented on patch set 3 10/19/21, 14:52
for reference: there was a namespace clash 'Felogin' vs. 'FrontendLogin' in ext_localconf vs getIdentifier()