71804[BUGFIX] Properly return path relative to public dir in FilePathSanitizer
Commit message
Review
-
Code review CR +2 Done
- Helmut Hummel +2
- Simon Gilli +1
- Robert Kärner +1
-
Verified V +2 Done
- Helmut Hummel +2
- Simon Gilli +1
- Robert Kärner +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1214
-
Florian Rival uploaded patch set 1 10/15/21, 10:58
-
core-ci voted on patch set 1 V -1 10/15/21, 11:07 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18165
-
Simon Gilli commented on patch set 1 CR -1 10/15/21, 11:46
Thanks for your patch. The correct fix for this issue is here https://review.typo3.org/c/Packages/TYPO3.CMS/+/71806 -
Helmut Hummel commented on patch set 1 CR -1 10/15/21, 11:47
A proper fix can be found here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71806FilePathSanitizer.php:122good job in identifying the place where this needs to be fixed. The fix itself isn't valid like this unfortuately though -
Florian Rival commented on patch set 1 10/18/21, 07:58
FilePathSanitizer.php:122ReplyThanks for the feedback.. But why don't you keep the unit test, it seems that this case is missing. -
Stefan Bürk commented on patch set 1 CR -1 10/18/21, 13:17
FilePathSanitizer.php:122ReplyYour added testcase is there in the patch linked by Simon and Helmut: publicAssetsInComposerModeResolvedCorrectly() => sanitizeCorrectlyResolvesPathsAndUrlsDataProvider() ``` 'legacy systems resolve private resources in public path' => [ 'EXT:frontend/Resources/Private/Templates/MainPage.html', 'typo3/sysext/frontend/Resources/Private/Templates/MainPage.html', ], ``` -
Helmut Hummel commented on patch set 1 10/26/21, 09:35
FilePathSanitizer.php:122Reply> But why don't you keep the unit test, it seems that this case is missing. Yes good point. It was missing. Additionally the tests did not cover other important areas, that is why I completely refactored them to do so. AND: You deserve the credits for this fix as well. That is why I will push an update here with a commit that reference you as author and will abandon my change set. Thanks again for your contribution! -
Helmut Hummel uploaded patch set 2 10/26/21, 09:37
-
Helmut Hummel voted on patch set 2 V +1 CR +1 10/26/21, 09:37
-
Simon Gilli voted on patch set 2 V +1 CR +1 10/26/21, 09:42
-
core-ci voted on patch set 2 V +1 10/26/21, 09:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18566
-
Robert Kärner voted on patch set 2 V +1 CR +1 10/26/21, 10:23
-
Helmut Hummel voted on patch set 2 V +2 CR +2 10/26/21, 11:48
-
Helmut Hummel merged patch set 3 10/26/21, 11:51