Review main Merged

71805[DOCS] Document changed behavior with Composer and extensions

Georg Ringer CR +2 V +2 Normal +63 −0 updated 10/25/21, 13:57

Commit message

With #94996 the behavior for composer based installations changed:

- All extensions are always active
- PackageStates.php is not used anymore
- ext_emconf.php is not used anymore

More information makes updates easier for integrators.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Simon Gilli +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Simon Gilli +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2734

Show 69 earlier messages
  1. Georg Ringer uploaded patch set 1 10/15/21, 11:04

  2. Georg Ringer commented on patch set 1 10/15/21, 11:06

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/15/21, 11:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18167

  4. Jochen Roth voted on patch set 1 V +1 CR +1 10/15/21, 11:56

  5. Mathias Brodala commented on patch set 2 10/15/21, 12:37

    Published edit on patch set 1.
  6. Mathias Brodala updated the commit message in patch set 3 10/15/21, 12:38

  7. Mathias Brodala voted on patch set 3 CR +1 10/15/21, 12:39

  8. core-ci voted on patch set 3 V +1 10/15/21, 12:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18183

  9. core-ci voted on patch set 2 V +1 10/15/21, 12:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18182

  1. Jochen Roth voted on patch set 3 V +1 CR +1 10/15/21, 13:41

  2. Benni Mack commented on patch set 3 CR -2 10/15/21, 13:42

    will update
  3. Christian Kuhn updated the commit message in patch set 4 10/17/21, 10:51

  4. core-ci voted on patch set 4 V +1 10/17/21, 11:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18239

  5. Simon Gilli commented on patch set 4 CR -1 10/18/21, 11:35

    As it turns out the ex_emconf.php is still needed by the EM see also https://typo3.slack.com/archives/C03AM9R17/p1634555443495500 Also TER and Tailor are still looking for this file.
  6. Helmut Hummel commented on patch set 4 10/18/21, 12:17

    Reply

    > As it turns out the ex_emconf.php is still needed by the EM This is a bug. > Also TER and Tailor are still looking for this file. Non Composer installation still require these files in extensions of course. The document here is here to clarify changes in Composer mode
  7. Oliver Klee commented on patch set 4 CR +1 10/18/21, 12:44

    I have proposed some changes.

    Important-95647-ComposerInstallationsAndExtensionUsage.rst:14

    I'd prefer this wording: `ext_emconf.php` not read in Composer mode anymore

    Important-95647-ComposerInstallationsAndExtensionUsage.rst:17 Unresolved

    Proposed change: The :file:`ext_emconf.php` is not read in Composer mode anymore. (It still is required for non-Composer installations and for uploads to the TER.)
  8. Mathias Brodala commented on patch set 4 10/18/21, 13:02

    Important-95647-ComposerInstallationsAndExtensionUsage.rst:14 Reply Unresolved

    We can simplify "not read" to "ignored" or "skipped", but yes, makes sense.
  9. Simon Gilli commented on patch set 4 10/18/21, 14:24

    Reply Unresolved

    Agree. Just mentioned it here because of the confusing which hopefully is solved now with the suggestions of Oliver.
  10. Benni Mack voted on patch set 4 CR 0 10/20/21, 06:45

  11. Benni Mack commented on patch set 5 10/23/21, 15:09

    Published edit on patch set 4.
  12. Benni Mack commented on patch set 5 10/23/21, 15:10

    Unresolved

    Updated the text. @georg @oli can you verify if this is OK for you? Also: I wasn't 100% sure, but is PackageStates.php also removed from Classic Mode installations? I don't think so, that's why I reworked this part a bit.
  13. core-ci voted on patch set 5 V +1 10/23/21, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18445

  14. Georg Ringer commented on patch set 5 V +1 CR +1 10/23/21, 16:00

    Important-95647-ComposerInstallationsAndExtensionUsage.rst:17

    I would remove "which is required for each TYPO3 extension" because it is not required anymore actually
  15. Oliver Klee voted on patch set 5 V +1 CR +1 10/23/21, 16:50

  16. Benni Mack commented on patch set 6 10/25/21, 12:22

    Published edit on patch set 5.
  17. core-ci voted on patch set 6 V +1 10/25/21, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18528

  18. Simon Gilli commented on patch set 7 10/25/21, 13:05

    Published edit on patch set 6.
  19. Simon Gilli commented on patch set 7 V +1 CR +1 10/25/21, 13:06

    fixed line lengths, please vote again.
  20. Simon Gilli commented on patch set 7 10/25/21, 13:07

    Important-95647-ComposerInstallationsAndExtensionUsage.rst:17 Reply

    Done
  21. core-ci voted on patch set 7 V +1 10/25/21, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18530

  22. Oliver Klee voted on patch set 7 CR +1 10/25/21, 13:37

  23. Benni Mack voted on patch set 7 V +1 CR +1 10/25/21, 13:47

  24. Georg Ringer voted on patch set 7 V +2 CR +2 10/25/21, 13:57

  25. Georg Ringer merged patch set 8 10/25/21, 13:57