71805[DOCS] Document changed behavior with Composer and extensions
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Klee +1
- Simon Gilli +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Simon Gilli +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2734
Show 69 earlier messages
-
Georg Ringer uploaded patch set 1 10/15/21, 11:04
-
Georg Ringer commented on patch set 1 10/15/21, 11:06
This change is ready for review. -
core-ci voted on patch set 1 V +1 10/15/21, 11:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18167
-
Jochen Roth voted on patch set 1 V +1 CR +1 10/15/21, 11:56
-
Mathias Brodala commented on patch set 2 10/15/21, 12:37
Published edit on patch set 1. -
Mathias Brodala updated the commit message in patch set 3 10/15/21, 12:38
-
Mathias Brodala voted on patch set 3 CR +1 10/15/21, 12:39
-
core-ci voted on patch set 3 V +1 10/15/21, 12:54 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18183
-
core-ci voted on patch set 2 V +1 10/15/21, 12:58 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18182
-
Jochen Roth voted on patch set 3 V +1 CR +1 10/15/21, 13:41
-
Benni Mack commented on patch set 3 CR -2 10/15/21, 13:42
will update -
Christian Kuhn updated the commit message in patch set 4 10/17/21, 10:51
-
core-ci voted on patch set 4 V +1 10/17/21, 11:08 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18239
-
Simon Gilli commented on patch set 4 CR -1 10/18/21, 11:35
As it turns out the ex_emconf.php is still needed by the EM see also https://typo3.slack.com/archives/C03AM9R17/p1634555443495500 Also TER and Tailor are still looking for this file. -
Helmut Hummel commented on patch set 4 10/18/21, 12:17
Reply
> As it turns out the ex_emconf.php is still needed by the EM This is a bug. > Also TER and Tailor are still looking for this file. Non Composer installation still require these files in extensions of course. The document here is here to clarify changes in Composer mode -
Oliver Klee commented on patch set 4 CR +1 10/18/21, 12:44
I have proposed some changes.Important-95647-ComposerInstallationsAndExtensionUsage.rst:14I'd prefer this wording: `ext_emconf.php` not read in Composer mode anymoreImportant-95647-ComposerInstallationsAndExtensionUsage.rst:17UnresolvedProposed change: The :file:`ext_emconf.php` is not read in Composer mode anymore. (It still is required for non-Composer installations and for uploads to the TER.) -
Mathias Brodala commented on patch set 4 10/18/21, 13:02
Important-95647-ComposerInstallationsAndExtensionUsage.rst:14Reply UnresolvedWe can simplify "not read" to "ignored" or "skipped", but yes, makes sense. -
Simon Gilli commented on patch set 4 10/18/21, 14:24
Reply Unresolved
Agree. Just mentioned it here because of the confusing which hopefully is solved now with the suggestions of Oliver. -
Benni Mack voted on patch set 4 CR 0 10/20/21, 06:45
-
Benni Mack commented on patch set 5 10/23/21, 15:09
Published edit on patch set 4. -
Benni Mack commented on patch set 5 10/23/21, 15:10
Unresolved
Updated the text. @georg @oli can you verify if this is OK for you? Also: I wasn't 100% sure, but is PackageStates.php also removed from Classic Mode installations? I don't think so, that's why I reworked this part a bit. -
core-ci voted on patch set 5 V +1 10/23/21, 15:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18445
-
Georg Ringer commented on patch set 5 V +1 CR +1 10/23/21, 16:00
Important-95647-ComposerInstallationsAndExtensionUsage.rst:17I would remove "which is required for each TYPO3 extension" because it is not required anymore actually -
Oliver Klee voted on patch set 5 V +1 CR +1 10/23/21, 16:50
-
Benni Mack commented on patch set 6 10/25/21, 12:22
Published edit on patch set 5. -
core-ci voted on patch set 6 V +1 10/25/21, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18528
-
Simon Gilli commented on patch set 7 10/25/21, 13:05
Published edit on patch set 6. -
Simon Gilli commented on patch set 7 V +1 CR +1 10/25/21, 13:06
fixed line lengths, please vote again. -
Simon Gilli commented on patch set 7 10/25/21, 13:07
Important-95647-ComposerInstallationsAndExtensionUsage.rst:17ReplyDone -
core-ci voted on patch set 7 V +1 10/25/21, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18530
-
Oliver Klee voted on patch set 7 CR +1 10/25/21, 13:37
-
Benni Mack voted on patch set 7 V +1 CR +1 10/25/21, 13:47
-
Georg Ringer voted on patch set 7 V +2 CR +2 10/25/21, 13:57
-
Georg Ringer merged patch set 8 10/25/21, 13:57