71806[BUGFIX] Properly return path relative to public dir in FilePathSanitizer
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1219
-
Helmut Hummel uploaded patch set 1 10/15/21, 11:41
-
Helmut Hummel updated the commit message in patch set 2 10/15/21, 11:48
-
core-ci voted on patch set 1 V +1 10/15/21, 11:57 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18173
-
core-ci voted on patch set 2 V +1 10/15/21, 12:04 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18174
-
Simon Gilli commented on patch set 2 10/15/21, 12:11
The change looks good but I got some questions regarding the unit test.FilePathSanitizerTest.php:71Why the be entry point?FilePathSanitizerTest.php:76Why within public?FilePathSanitizerTest.php:77Why adding /public here?FilePathSanitizerTest.php:80And here? -
Helmut Hummel uploaded patch set 3 10/15/21, 12:51
-
Helmut Hummel uploaded patch set 4 10/15/21, 12:56
-
Helmut Hummel commented on patch set 4 10/15/21, 12:58
FilePathSanitizerTest.php:71ReplyDoneFilePathSanitizerTest.php:76Replyproject path should stay, correct. fixed thatFilePathSanitizerTest.php:77Replyto simulate a composer installation where project path and public path differFilePathSanitizerTest.php:80ReplyDone -
Helmut Hummel uploaded patch set 5 10/15/21, 12:59
-
Simon Gilli commented on patch set 5 V -1 10/15/21, 13:01
On it... -
core-ci voted on patch set 3 V +1 10/15/21, 13:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18187
-
core-ci voted on patch set 4 V +1 10/15/21, 13:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18188
-
core-ci voted on patch set 5 V +1 10/15/21, 13:15 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18189
-
Helmut Hummel uploaded patch set 6 10/15/21, 13:56
-
core-ci voted on patch set 6 V +1 10/15/21, 14:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18193
-
Simon Gilli updated the commit message in patch set 7 10/15/21, 15:04
-
Simon Gilli voted on patch set 7 V +1 CR +1 10/15/21, 15:08
-
core-ci voted on patch set 7 V +1 10/15/21, 15:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18195
-
Helmut Hummel abandoned the change 10/26/21, 09:38
Abandoned in favor of the original authorship https://review.typo3.org/c/Packages/TYPO3.CMS/+/71804