Review main Merged

71807[TASK] gitlab-ci: Enable FF_ENABLE_JOB_CLEANUP flag

Christian Kuhn CR +2 V +2 Easy +3 −0 updated 10/15/21, 12:28

Commit message

This gitlab-runner flag invokes a 'git clean' command
at the end of each job run, after uploading caches, to
remove any files that have been created by the job.

Until now, this cleanup has been done at the start
of the next job only, so all this temp data - around
half a gig to a gig per job - has been lying around
in the gitlab-runner docker cache volumes.

This is super useful since our runners work with a
ram driven var/lib/docker, this cleanup significantly
reduces ram usage on the runners.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 10/15/21, 11:56

  2. Christian Kuhn updated the commit message in patch set 2 10/15/21, 12:10

  3. core-ci voted on patch set 1 V +1 10/15/21, 12:11 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18176

  4. Jochen Roth voted on patch set 2 V +1 CR +1 10/15/21, 12:11

  5. Christian Kuhn commented on patch set 2 10/15/21, 12:18

    note: i'll take the freedom to merge this as soon as it goes green.
  6. core-ci voted on patch set 2 V +1 10/15/21, 12:25 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18179

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 10/15/21, 12:28

  8. Christian Kuhn merged patch set 3 10/15/21, 12:28