Review main Merged

71809[TASK] Add support for PHP 8.1 functions

Benni Mack CR +2 V +2 Easy +3 −2 updated 10/15/21, 12:46

Commit message

This change adds the symfony/polyfill-php81
package as dependency.

In addition, EXT:form does not explicitly
depend on symfony/polyfill-php80 anymore,
as this is not needed, since EXT:core
handles this dependency directly.

Used composer commands:

> composer req symfony/polyfill-php81
> composer req symfony/polyfill-php81 -d typo3/sysext/core --no-update
> composer remove symfony/polyfill-php80 -d typo3/sysext/form

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 45

  1. Benni Mack uploaded patch set 1 10/15/21, 12:16

  2. Oliver Hader commented on patch set 1 V +1 CR +1 10/15/21, 12:31

    Looks good and `array_is_list` behaves the same as in PHP 8.1 ``` docker run -i php:8.1.0RC4-cli-buster php -a Interactive shell php > $items = ['a', 'b', 'c', 'd']; $items = ['a', 'b', 'c', 'd']; php > var_dump(array_is_list($items)); var_dump(array_is_list($items)); bool(true) php > unset($items[1]); unset($items[1]); php > var_dump(array_is_list($items)); var_dump(array_is_list($items)); bool(false) var_dump($items === array_values($items)); bool(false) ```
  3. core-ci voted on patch set 1 V +1 10/15/21, 12:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18181

  4. Benni Mack voted on patch set 1 V +2 CR +2 10/15/21, 12:46

  5. Benni Mack merged patch set 2 10/15/21, 12:46