71809[TASK] Add support for PHP 8.1 functions
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 4
Review log 45
-
Benni Mack uploaded patch set 1 10/15/21, 12:16
-
Oliver Hader commented on patch set 1 V +1 CR +1 10/15/21, 12:31
Looks good and `array_is_list` behaves the same as in PHP 8.1 ``` docker run -i php:8.1.0RC4-cli-buster php -a Interactive shell php > $items = ['a', 'b', 'c', 'd']; $items = ['a', 'b', 'c', 'd']; php > var_dump(array_is_list($items)); var_dump(array_is_list($items)); bool(true) php > unset($items[1]); unset($items[1]); php > var_dump(array_is_list($items)); var_dump(array_is_list($items)); bool(false) var_dump($items === array_values($items)); bool(false) ``` -
core-ci voted on patch set 1 V +1 10/15/21, 12:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18181
-
Benni Mack voted on patch set 1 V +2 CR +2 10/15/21, 12:46
-
Benni Mack merged patch set 2 10/15/21, 12:46