Review main Merged

71832[TASK] Have a FunctionalDeprecated test suite

Christian Kuhn CR +2 V +2 Expert +1147 −181 updated 10/15/21, 18:56

Commit message

With functional tests now failing on warnings and notices
and *showing* deprecations, the next step is to make sure
the functional test suite does not trigger deprecated
code anymore. The strategy is similar to "UnitDeprecated":
All functional tests that actively test deprecated code
are moved to a dedicated test suite that *does not* fail
on deprecations, while the main functional test suite
*does* fail on deprecations.

This helps to ensure core code does not call deprecated
functionality.

The patch:
* Adds a FunctionalDeprecated test suite as new home
  for tests that test deprecated subjects like the
  deprecated extbase ObjectManager.
* Moves and splits existing tests to FunctionalDeprecated,
  including fixtures as needed.
* Adds the test suite to runTests.sh and adapts the
  docker setup accordingly.
* Adds FunctionalDeprecated suite to gitlab-ci pre-merge
  and nightly in various php / dbms combinations.
* Enables convertDeprecationsToExceptions="true" for
  the main functional test suite and "false" for the
  new FunctionalDeprecated suite.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Jochen Roth +1
    • Simon Gilli +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 23

Show 3 more files

Review log 1524

  1. Christian Kuhn uploaded patch set 1 10/15/21, 13:06

  2. core-ci voted on patch set 1 V -1 10/15/21, 13:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18190

  3. Christian Kuhn uploaded patch set 2 10/15/21, 13:24

  4. core-ci voted on patch set 2 V -1 10/15/21, 13:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18191

  5. Christian Kuhn uploaded patch set 3 10/15/21, 15:02

  6. core-ci voted on patch set 3 V -1 10/15/21, 15:17 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18194

  7. Christian Kuhn uploaded patch set 4 10/15/21, 16:03

  8. core-ci voted on patch set 4 V -1 10/15/21, 16:05 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18196

  9. Christian Kuhn uploaded patch set 5 10/15/21, 16:07

  10. core-ci voted on patch set 5 V +1 10/15/21, 16:20 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18197

  11. Christian Kuhn uploaded patch set 6 10/15/21, 16:43

  12. Christian Kuhn updated the commit message in patch set 7 10/15/21, 16:45

  13. Christian Kuhn updated the commit message in patch set 8 10/15/21, 16:56

  14. core-ci voted on patch set 6 V +1 10/15/21, 16:56 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18198

  15. core-ci voted on patch set 7 V +1 10/15/21, 17:02 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18199

  16. core-ci voted on patch set 8 V +1 10/15/21, 17:14 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18200

  17. Stefan Bürk voted on patch set 8 V +1 CR +1 10/15/21, 17:42

  18. Georg Ringer voted on patch set 8 CR +1 10/15/21, 18:16

  19. Jochen Roth voted on patch set 8 V +1 CR +1 10/15/21, 18:19

  20. Anja Leichsenring voted on patch set 8 V +1 CR +1 10/15/21, 18:20

  21. Simon Gilli voted on patch set 8 CR +1 10/15/21, 18:23

  22. core-ci commented on patch set 8 10/15/21, 18:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18201

  23. Christian Kuhn voted on patch set 8 V +2 CR +2 10/15/21, 18:56

  24. Christian Kuhn merged patch set 9 10/15/21, 18:56