Review main Merged

71833[TASK] phpunit: Enable failOnRisky flag

Christian Kuhn CR +2 V +2 Easy +4 −0 updated 10/15/21, 14:36

Commit message

Let tests fail that are considered 'risky' by phpunit.
We recently had a case during development where this
would have been useful, the flag should be enabled.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/15/21, 13:27

  2. core-ci voted on patch set 1 V +1 10/15/21, 13:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18192

  3. Jochen Roth voted on patch set 1 V +1 CR +1 10/15/21, 13:46

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 10/15/21, 13:58

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/15/21, 14:36

  6. Christian Kuhn merged patch set 2 10/15/21, 14:36