Review main Merged

71836[BUGFIX] Avoid php8.1 fatal error in FileSessionHandler

Stefan Bürk CR +2 V +2 Easy +6 −0 updated 10/16/21, 09:02

Commit message

PHP8.1 added return types for some internal php
functions, class methods and interfaces, like it
has been added in php8.0 for internal function
arguments. Generally this leads to deprecation
messages.

Classes extending internal classes or implementing
php interfaces, must implement compatible return
types. As a workaround for older php version which
do not support return types, an attribute can be
added to suppress this message until return types
can be adjusted.

The patch adds the according '#[ReturnTypeWillChange]'
attribute to add PHP 8.1 compatibility and keep 7.4.

This patch fixes a fatal php 8.1 error found by
functional tests.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 812

  1. Stefan Bürk uploaded patch set 1 10/15/21, 23:14

  2. Stefan Bürk updated the commit message in patch set 2 10/15/21, 23:15

  3. Stefan Bürk updated the commit message in patch set 3 10/15/21, 23:29

  4. core-ci voted on patch set 2 V +1 10/15/21, 23:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18214

  5. core-ci voted on patch set 1 V +1 10/15/21, 23:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18213

  6. core-ci voted on patch set 3 V +1 10/15/21, 23:48 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18215

  7. Christian Kuhn updated the commit message in patch set 4 10/16/21, 07:49

  8. core-ci voted on patch set 4 V +1 10/16/21, 08:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18218

  9. Christian Kuhn voted on patch set 4 V +1 CR +1 10/16/21, 08:18

  10. Wouter Wolters voted on patch set 4 V +1 CR +1 10/16/21, 09:02

  11. Christian Kuhn voted on patch set 4 V +2 CR +2 10/16/21, 09:02

  12. Christian Kuhn merged patch set 5 10/16/21, 09:02