Review main Merged

71839[BUGFIX] Fix type error when value in PaddingViewHelper is omitted

Chris Müller CR +2 V +2 Easy +5 −1 updated 10/17/21, 10:39

Commit message

As the value is optional, null is given to
StringUtility::multibyteStringPad() which throwed a type error.
Also an integer value is also valid, so casting the value is the
way to go.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Sybille Peters +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1013

  1. Chris Müller uploaded patch set 1 10/16/21, 20:14

  2. Chris Müller updated the commit message in patch set 2 10/16/21, 20:19

  3. Chris Müller updated the commit message in patch set 3 10/16/21, 20:25

  4. core-ci voted on patch set 1 V +1 10/16/21, 20:27 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18229

  5. Sybille Peters commented on patch set 3 10/16/21, 20:30

    Thank you for spotting this! You might want to add Relesaes 10.4 too. The related patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/71032 was (later) backported to 10.4, though not originally declared for 10.4 : https://review.typo3.org/c/Packages/TYPO3.CMS/+/71623 Can a type error also occur in ContentObjectRenderer? https://review.typo3.org/c/Packages/TYPO3.CMS/+/71032/6/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
  6. Chris Müller commented on patch set 3 10/16/21, 20:37

    Reply

    Added 10.4 already :-) I assume it does not occur in ContentObjectRenderer, it should be a string (according to @param) and comes from TypoScript (which is always a string AFAIK).
  7. core-ci voted on patch set 2 V +1 10/16/21, 20:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18230

  8. Sybille Peters voted on patch set 3 CR +1 10/16/21, 20:43

  9. core-ci voted on patch set 3 V +1 10/16/21, 20:44 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18231

  10. Simon Schaufelberger voted on patch set 3 V +1 CR +1 10/16/21, 21:08

  11. Oliver Klee voted on patch set 3 CR +1 10/16/21, 21:41

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 10/17/21, 10:39

  13. Christian Kuhn merged patch set 4 10/17/21, 10:39