Review 10.4 Merged

71840[BUGFIX] Fix type error when value in PaddingViewHelper is omitted

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 10/17/21, 11:06

Commit message

As the value is optional, null is given to
StringUtility::multibyteStringPad() which throwed a type error.
Also an integer value is also valid, so casting the value is the
way to go.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Chris Müller +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Chris Müller +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 10/17/21, 10:43

  2. Christian Kuhn commented on patch set 1 10/17/21, 10:44

    skipping the test in v10 backport since the v11 VH tests have been massively refactored and the v10 tests aren't of too much help for this straight change.
  3. core-ci voted on patch set 1 V +1 10/17/21, 10:59 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18237

  4. Chris Müller voted on patch set 1 V +1 CR +1 10/17/21, 11:03

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 10/17/21, 11:06

  6. Christian Kuhn merged patch set 2 10/17/21, 11:06