71843[BUGFIX] Prevent PHP 8 warning exception due to missing array keys
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2025
-
Daniel Dorndorf uploaded patch set 1 10/17/21, 13:56
-
Simon Gilli commented on patch set 1 CR -1 10/17/21, 14:08
-
Simon Gilli commented on patch set 1 10/17/21, 14:08
no 11.5 branch so far, please remove. -
Daniel Dorndorf uploaded patch set 2 10/17/21, 14:11
-
Daniel Dorndorf commented on patch set 2 10/17/21, 14:14
Reply
okay, but will this be added to the next 11.5 patch?FrontendConfigurationManager.php:159ReplyYou're right, did changed this -
Daniel Dorndorf uploaded patch set 3 10/17/21, 14:16
-
core-ci voted on patch set 1 V +1 10/17/21, 14:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18243
-
Simon Gilli commented on patch set 3 CR -1 10/17/21, 14:23
Reply
Yes. Currenlty master is 11.5. Branch off will happen in some months, so long you do not need it here.FrontendConfigurationManager.php:158We do not use Yoda conditions in the core. The rest looks fine imho. -
core-ci voted on patch set 2 V -1 10/17/21, 14:25 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18244
-
Daniel Dorndorf uploaded patch set 4 10/17/21, 14:25
-
Daniel Dorndorf commented on patch set 4 10/17/21, 14:26
Reply
okFrontendConfigurationManager.php:158ReplyAlso adjusted this -
core-ci voted on patch set 3 V +1 10/17/21, 14:30 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18245
-
core-ci voted on patch set 4 V +1 10/17/21, 14:39 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18246
-
Daniel Dorndorf commented on patch set 4 10/17/21, 14:43
FrontendConfigurationManager.php:159ReplyDone -
Simon Gilli commented on patch set 4 CR +1 10/17/21, 14:47
Great thx! -
Christian Kuhn commented on patch set 4 10/17/21, 15:42
FrontendConfigurationManager.php:158funny. did run into the very same issue within functional tests recently and decided to not fix it in code, but to prepare the test better. -
Simon Gilli commented on patch set 4 10/17/21, 16:15
FrontendConfigurationManager.php:158ReplyLooks there are some real edge cases here. Not sure if it's a valid and recommended usage though but fixing does not hurt imho... -
Christian Kuhn commented on patch set 4 10/17/21, 19:57
FrontendConfigurationManager.php:158Replyyeah. guess we should sanitize it. alternative is an exception but that would be breaking ... so, i'd go with the v11 sanitation as proposed. for v12 it's prettyl likely we'll kill ConfigurationManager entirely since it's a trainwreck of an api anyway and is on my kill-list for quite some time already since it hurts. -
Christian Kuhn updated the commit message in patch set 5 10/17/21, 19:58
-
Oliver Klee voted on patch set 5 CR +1 10/17/21, 20:05
-
Stefan Bürk voted on patch set 5 V +1 CR +1 10/17/21, 20:09
-
Christian Kuhn commented on patch set 5 10/17/21, 20:11
FrontendConfigurationManager.php:158ReplyDone -
core-ci voted on patch set 5 V +1 10/17/21, 20:18 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18265
-
Christian Kuhn voted on patch set 5 V +2 CR +2 10/17/21, 20:39
-
Christian Kuhn merged patch set 6 10/17/21, 20:39
FrontendConfigurationManager.php:159