Review main Merged

71844[TASK] Avoid call_user_func() in phpunit bootstrap

Stefan Bürk CR +2 V +2 Easy +4 −4 updated 10/17/21, 17:22

Commit message

This patch avoid call_user_func() from phpunit
bootstrap corresponding to merged change in the
testing framework.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1015

  1. Stefan Bürk uploaded patch set 1 10/17/21, 14:32

  2. Stefan Bürk rebased onto patch set 2 10/17/21, 14:33

  3. core-ci voted on patch set 1 V +1 10/17/21, 14:47 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18247

  4. core-ci voted on patch set 2 V +1 10/17/21, 14:52 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18248

  5. Stefan Bürk commented on patch set 2 10/17/21, 15:00

  6. core-ci voted on patch set 2 V -1 10/17/21, 15:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18250

  7. Simon Gilli commented on patch set 2 10/17/21, 16:06

    Reply

    Is there a token available for the upstream repo? If yes just push my branch to the upstream instead...
  8. core-ci commented on patch set 2 10/17/21, 16:08 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18250

  9. Stefan Bürk commented on patch set 2 10/17/21, 16:32

    Reply

    It's alright. Min/max hase some issues with fork repositories and branches. Lock version went through. Your pr was already merged in testingframework. Will cleanup this to the changes in the bootstrap files now, push will follow shortly.
  10. Stefan Bürk uploaded patch set 3 10/17/21, 16:35

  11. core-ci voted on patch set 3 V +1 10/17/21, 16:50 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/18252

  12. Christian Kuhn voted on patch set 3 V +1 CR +1 10/17/21, 17:20

  13. Simon Gilli voted on patch set 3 V +1 CR +1 10/17/21, 17:21

  14. Christian Kuhn voted on patch set 3 V +2 CR +2 10/17/21, 17:21

  15. Christian Kuhn merged patch set 4 10/17/21, 17:22